Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump C++ standard to 17 due to inline extension #21

Closed
wants to merge 1 commit into from

Conversation

klemensn
Copy link
Contributor

.../noson/src/private/byteorder.h:57:8: warning: inline variables are a C++17 extension [-Wc++17-extensions]
static inline int16_t swap16(int16_t val)
       ^

```
.../noson/src/private/byteorder.h:57:8: warning: inline variables are a C++17 extension [-Wc++17-extensions]
static inline int16_t swap16(int16_t val)
       ^
```
@janbar
Copy link
Owner

janbar commented Feb 10, 2024

That is my code from C, so a function static inline. It is not a variable. As it is included in c++ source, I have to remove static keyword.

@klemensn klemensn closed this Feb 10, 2024
@klemensn klemensn deleted the cxx-standard branch February 10, 2024 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants