Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix includedir #19

Merged
merged 1 commit into from
Feb 10, 2024
Merged

Fix includedir #19

merged 1 commit into from
Feb 10, 2024

Conversation

klemensn
Copy link
Contributor

@klemensn klemensn commented Feb 7, 2024

noson-app code uses <noson/*.h>, so building that against noson as system library will fail as <noson/noson/*.h> does not exist.

This is the case on OpenBSD where /usr/local/ is the default prefix. On Linux, the default is /usr/, i.e. the same as the default prefix.

My guess it's been working by accident so far.

noson-app code uses `<noson/*.h>`, so building that against noson as
system library will fail as `<noson/noson/*.h>` does not exist.

This is the case on OpenBSD where /usr/local/ is the default prefix.
On Linux, the default is /usr/, i.e. the same as the default prefix.

My guess it's been working by accident so far.
@klemensn
Copy link
Contributor Author

klemensn commented Feb 10, 2024

Installed headers must be in a subfolder in the include dir i.e "noson", as headers could override others file of the system.
I guess the issue is not here, but in the other project noson-app. Also that is preferable to link noson-app statically with this project because the C++ ABI is not stable.

That's fine, splitting it out as its own lib remains preferred for me as package maintainer.

That is the reason noson-app has a submodule that points to a particular commit and it is linked statically with it.
I will check the issue trying to link dynamically...

The issue is not static vs. dynamic, but bundled vs. extern/system library.

Using libnoson.a won't change how noson-app looks for the header.

@janbar
Copy link
Owner

janbar commented Feb 10, 2024

Sorry, I didn't see this commit fix pkg config and cmake config. So it is OK.

@janbar janbar merged commit 318d0e7 into janbar:master Feb 10, 2024
1 of 2 checks passed
@janbar
Copy link
Owner

janbar commented Feb 10, 2024

@klemensn , Thanks

@klemensn klemensn deleted the includedir branch February 10, 2024 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants