From 9c40feec3669be10153ab9582e7db98b42acdd2b Mon Sep 17 00:00:00 2001 From: Yurii Date: Thu, 6 Feb 2025 10:36:22 +0100 Subject: [PATCH] #1019: support spaces in RangeVersion expression, and add corresponding unit test (#1020) --- .../main/java/com/devonfw/tools/ide/version/VersionRange.java | 4 ++-- .../java/com/devonfw/tools/ide/version/VersionRangeTest.java | 1 + 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/cli/src/main/java/com/devonfw/tools/ide/version/VersionRange.java b/cli/src/main/java/com/devonfw/tools/ide/version/VersionRange.java index d4f1c621f..4ceb86cf1 100644 --- a/cli/src/main/java/com/devonfw/tools/ide/version/VersionRange.java +++ b/cli/src/main/java/com/devonfw/tools/ide/version/VersionRange.java @@ -174,11 +174,11 @@ public static VersionRange of(String value) { max = min; } else { String minString = value.substring(0, index); - if (!minString.isEmpty()) { + if (!minString.isBlank()) { min = VersionIdentifier.of(minString); } String maxString = value.substring(index + 1); - if (!maxString.isEmpty()) { + if (!maxString.isBlank()) { max = VersionIdentifier.of(maxString); } } diff --git a/cli/src/test/java/com/devonfw/tools/ide/version/VersionRangeTest.java b/cli/src/test/java/com/devonfw/tools/ide/version/VersionRangeTest.java index e695f2902..7a1c8b398 100644 --- a/cli/src/test/java/com/devonfw/tools/ide/version/VersionRangeTest.java +++ b/cli/src/test/java/com/devonfw/tools/ide/version/VersionRangeTest.java @@ -16,6 +16,7 @@ public void testOf() { checkVersionRange("[1.2,3]", "1.2", "3", BoundaryType.CLOSED); checkVersionRange("1,)", "1", null, BoundaryType.RIGHT_OPEN); checkVersionRange("[1,)", "1", null, BoundaryType.RIGHT_OPEN); + checkVersionRange("[1, )", "1", null, BoundaryType.RIGHT_OPEN); checkVersionRange("(1.2,3.4", "1.2", "3.4", BoundaryType.LEFT_OPEN); checkVersionRange("(1.2,3.4]", "1.2", "3.4", BoundaryType.LEFT_OPEN); checkVersionRange("1.2,3.4)", "1.2", "3.4", BoundaryType.RIGHT_OPEN);