descriptives: add weights support #425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raviselker
force-pushed
the
feature/weighted-descriptives
branch
from
42d44d5 to
54ce215
Compare
Implements weights support for a number of descriptive statistics. Not all descriptives functionality is supported yet (most notable, the plots), but the user gets a warning message when they select an unsupported option.
raviselker
force-pushed
the
feature/weighted-descriptives
branch
from
753de50 to
a90cd05
Compare
Previously, weighted descriptive stats were shown as missing values in the table. This commit changes this to NaN values. Also adds a "not supported yet" footnote for the non transposed table
raviselker
force-pushed
the
feature/weighted-descriptives
branch
from
a90cd05 to
179d8e5
Compare
|
did some testing; throws an error with quartiles 
|
|
Good catch! For some reason I was unable to replicate it in my R version (maybe a different way of dealing with NA values in if statements between the jamovi R version and my local R version), but I was able to test it in jamovi using your example. I added a commit that fixes this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements weights support for a number of descriptive statistics. Not all descriptives functionality is supported yet (most notable, the plots), but the user gets a warning message when they select an unsupported option.