Skip to content
This repository was archived by the owner on Jan 18, 2024. It is now read-only.

Update the library #59

Open
jamesplease opened this issue Feb 12, 2019 · 5 comments
Open

Update the library #59

jamesplease opened this issue Feb 12, 2019 · 5 comments

Comments

@jamesplease
Copy link
Owner

It's been a few years since I wrote this, but it's my most popular library by downloads. I should update it!

  1. Update to the latest Node
  2. Fix builds
  3. Modernize the repository

This won't involve any code changes, and no npm releases. It'll simply be a repository refresher.
@gndelia
Copy link

gndelia commented May 13, 2019

Do you need some help? I would love to contribute.

@jamesplease
Copy link
Owner Author

Sure. Feel free to make a PR; I'd be happy to review it!

gndelia added a commit to gndelia/moment-business that referenced this issue May 18, 2019
@gndelia
Updated versions of most of devDependencies. Removed run-sequence dep…
8f37ea2 
…endency. Pending to upgrade istanbul to nyc and 6to5 to babel. Pending to review coverage. Updated sinon function in tests setup. jamesplease#59
gndelia added a commit to gndelia/moment-business that referenced this issue May 18, 2019
@gndelia
Updated versions of most of devDependencies. Removed run-sequence dep…
504000b 
…endency. Pending to upgrade istanbul to nyc and 6to5 to babel. Pending to review coverage. Updated sinon function in tests setup. jamesplease#59
@gndelia gndelia mentioned this issue May 18, 2019
Closed
@gndelia
Copy link

gndelia commented May 18, 2019 •
edited
Loading

Hi!

I created a WIP PR so you can review it - I would like to know your opinions on the approach I am taking and to verify you agree on the changes I propose before I do them

This is a list of I think I should do (those checked are already available in the PR)

dependencies

  • update browserify to the latest version
  • update chai to the latest version
  • update del to the latest version
  • replace esperanto to some other bundler (webpack? rollup? some babel boilerplate generator?)
  • update glob to the latest version
  • update gulp to the latest version
  • remove gulp-6to5 - it should be replaced by Babel.
  • update gulp-file and gulp-filter to the latest version
  • remove gulp-istanbul - We should use nyc instead (review how to integrate with gulp)
  • replace jscs and jshint with eslint (jscs is deprecated and provides more functionality than just jshint)
  • replace gulp-uglifyjs with gulp-uglify
  • update to the latest versions of gulp-livereload, gulp-load-plugins, gulp-mocha, gulp-notify, gulp-plumber, gulp-rename, gulp-sourcemaps, isparta, jshint-stylish (to be removed, though), mkdirp, mocha, sinon, sinon-chai, underscore, vinyl-source-stream
  • remove run-sequence (gulp 4.0 comes with native support)

gulpfile

  • Fix bundling to UMD modules and ES6 modules
  • Review everything works fine with bower
  • Use babel to transpile code (replacing the deprecated 6to5)
  • Fix Coverage
  • replaced functions with arrow functions

CI

  • update travis so it uses latest nodejs version (12, unless you want to continue with LTS which is 10.x.x)

@gndelia
Copy link

gndelia commented Jun 12, 2019

hey @jamesplease did you have the chance to check the changes? Should/can I continue this way? I would not like to continue if you don't agree with the path I am taking..

@gndelia
Copy link

gndelia commented Oct 2, 2019

hey @jamesplease is this alive?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gndelia @jamesplease