Make config test exit with error code if broken #1577
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per discussion with @cpina, make
-t
exit non-zero (I picked2
) if something isn't right with the config. Mostly this covers using a monitor/alerter/logger type which isn't known; other config errors currently will just throw an exception and exit 1 still.If not testing the config, then the previous behaviour is currently retained: SimpleMonitor will try to continue with the config it did load. Not sure if that's the best choice yet; it probably should exit if the config is broken either way.