Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

copy sort.go, span.go, spanref.go, trace.go, time.go #124

Closed
wants to merge 3 commits into from
Closed

copy sort.go, span.go, spanref.go, trace.go, time.go #124

wants to merge 3 commits into from

Conversation

danish9039
Copy link
Contributor

@danish9039 danish9039 commented Jan 21, 2025 •
edited
Loading

Which problem is this PR solving?

Description of the changes

  • copy sort.go,span.go , spanref.go , trace.go , time.goto jaeger-idl/model/v1

How was this change tested?

Checklist

yurishkuro
yurishkuro reviewed Jan 21, 2025
View reviewed changes
Copy link
Member

@yurishkuro yurishkuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what about all the tests?

@danish9039
copy keyvalue.go,sort.go,span.go,spanref.go
9ae5b3e 
Signed-off-by: danish9039 <danishsiddiqui040@gmail.com>
@danish9039
add tests for sort.go,span.go,spanref.go
680c8c2 
Signed-off-by: danish9039 <danishsiddiqui040@gmail.com>
@danish9039
Copy link
Contributor Author

what about all the tests?

added sort_test.go , span_test.go , spanref_test.go

@danish9039 danish9039 changed the title copy keyvalue.go,sort.go,span.go,spanref.go copy sort.go,span.go,spanref.go Jan 21, 2025
@danish9039 danish9039 changed the title copy sort.go,span.go,spanref.go copy sort.go,span.go,spanref.go Jan 21, 2025
@danish9039
..
f2ce6ed 
Signed-off-by: danish9039 <danishsiddiqui040@gmail.com>
@danish9039 danish9039 changed the title copy sort.go,span.go,spanref.go copy sort.go,span.go,spanref.go, trace.go , time.go Jan 21, 2025
@danish9039 danish9039 changed the title copy sort.go,span.go,spanref.go, trace.go , time.go copy sort.go, span.go, spanref.go, trace.go , time.go Jan 21, 2025
@danish9039 danish9039 changed the title copy sort.go, span.go, spanref.go, trace.go , time.go copy sort.go, span.go, spanref.go, trace.go, time.go Jan 21, 2025
@yurishkuro
Copy link
Member

done in the other PRs. Thanks.

@yurishkuro yurishkuro closed this Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yurishkuro yurishkuro yurishkuro left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danish9039 @yurishkuro