Add model/v1 #118
Merged
Add model/v1 #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 20, 2025
yurishkuro
added a commit
to jaegertracing/jaeger
that referenced
this pull request
Jan 20, 2025
## Which problem is this PR solving? - Part of #6494 ## Description of the changes - Bump jaeger-idl submodule - Adjust code gen to account for different custom types due to jaegertracing/jaeger-idl#118 ## How was this change tested? - CI Signed-off-by: Yuri Shkuro <github@ysh.us>
Manik2708
pushed a commit
to Manik2708/jaeger
that referenced
this pull request
Jan 21, 2025
## Which problem is this PR solving? - Part of jaegertracing#6494 ## Description of the changes - Bump jaeger-idl submodule - Adjust code gen to account for different custom types due to jaegertracing/jaeger-idl#118 ## How was this change tested? - CI Signed-off-by: Yuri Shkuro <github@ysh.us>
This was referenced Jan 21, 2025
yurishkuro
added a commit
to jaegertracing/jaeger
that referenced
this pull request
Jan 21, 2025
## Which problem is this PR solving? - Part of #6571 - Follow-up to jaegertracing/jaeger-idl#118 ## Description of the changes - Separate model files into more independent pieces that are easier to move to jaeger-idl ## How was this change tested? - CI Signed-off-by: Yuri Shkuro <github@ysh.us>
4 tasks
yurishkuro
pushed a commit
to jaegertracing/jaeger
that referenced
this pull request
Jan 21, 2025
) ## Which problem is this PR solving? - Part of #6571 - Follow-up to jaegertracing/jaeger-idl#118 ## Description of the changes - Separate model files into more independent pieces that are easier to move to jaeger-idl ## How was this change tested? - `go test ./model/` - `go test ./internal/sampling/samplingstrategy/adaptive/` ## Checklist - [x] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [x] I have signed all commits - [ ] I have added unit tests for the new functionality - [ ] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `npm run lint` and `npm run test` --------- Signed-off-by: nabil salah <nabil.salah203@gmail.com>
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Description of the changes
model.protointomodel/v1packagejaegerrepomodel/that are required by api_v2, such as TraceID, SpanID, andFlagsrequired bymodelgo.modto make it into importable librarygo testto CIHow was this change tested?
go test ./model/v1Checklist
jaeger:make lint testjaeger-ui:npm run lintandnpm run test