Skip to content

Commit

Permalink
Extract url for scripts into variable (#141)
Browse files Browse the repository at this point in the history
## Which problem is this PR solving?
- part of jaegertracing/jaeger#6570

## Description of the changes
- extracted`
https://raw.githubusercontent.com/jaegertracing/jaeger/main/scripts`
into a variable `$(SCRIPTS_URL)`
#121 (comment)

## How was this change tested?
- 

## Checklist
- [X] I have read
https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md
- [x] I have signed all commits
- [x] I have added unit tests for the new functionality
- [x] I have run lint and test steps successfully
  - for `jaeger`: `make lint test`
  - for `jaeger-ui`: `npm run lint` and `npm run test`

Signed-off-by: danish9039 <danishsiddiqui040@gmail.com>
  • Loading branch information
danish9039 authored Jan 31, 2025
1 parent 86b800d commit d1d9a21
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions Makefile
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
# Copyright (c) 2023 The Jaeger Authors.
# SPDX-License-Identifier: Apache-2.0
SCRIPTS_URL = https://raw.githubusercontent.com/jaegertracing/jaeger/main/scripts

JAEGER_IMPORT_PATH = github.com/jaegertracing/jaeger-idl

Expand Down Expand Up @@ -228,9 +229,9 @@ lint-imports: setup-lint-scripts
.PHONY: setup-lint-scripts
setup-lint-scripts:
@mkdir -p .scripts/lint
@curl -s -o .scripts/lint/import-order-cleanup.py https://raw.githubusercontent.com/jaegertracing/jaeger/main/scripts/lint/import-order-cleanup.py
@curl -s -o .scripts/lint/import-order-cleanup.py $(SCRIPTS_URL)/lint/import-order-cleanup.py
@chmod +x .scripts/lint/import-order-cleanup.py
@curl -s -o .scripts/lint/updateLicense.py https://raw.githubusercontent.com/jaegertracing/jaeger/main/scripts/lint/updateLicense.py
@curl -s -o .scripts/lint/updateLicense.py $(SCRIPTS_URL)/lint/updateLicense.py
@chmod +x .scripts/lint/updateLicense.py

.PHONY: fmt
Expand Down

0 comments on commit d1d9a21

Please sign in to comment.