Skip to content

Commit

Permalink
return to vtk+plotly installation from from the net
Browse files Browse the repository at this point in the history
(Probably) due to unclear browser caching issues predominantly with vtk.
Need to learn more about this...
  • Loading branch information
j-fu committed Feb 26, 2023
1 parent b0de0d9 commit 0ad46f4
Show file tree
Hide file tree
Showing 5 changed files with 3 additions and 26 deletions.
2 changes: 1 addition & 1 deletion Project.toml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name = "PlutoVista"
uuid = "646e1f28-b900-46d7-9d87-d554eb38a413"
authors = ["Juergen Fuhrmann <juergen.fuhrmann@wias-berlin.de>"]
version = "0.8.23"
version = "0.8.24"

[deps]
ColorSchemes = "35d6a980-a343-548e-a6ea-1d62b119f2f4"
Expand Down
8 changes: 0 additions & 8 deletions imports/plotly.min.js

This file was deleted.

9 changes: 0 additions & 9 deletions imports/vtk.js

This file was deleted.

5 changes: 1 addition & 4 deletions src/plutoplotlyplot.jl
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,6 @@ function PlutoPlotlyPlot(;resolution=(300,300), kwargs...)
end


const plotly = read(joinpath(@__DIR__, "..", "imports", "plotly.min.js"), String)
const plutoplotlyplot = read(joinpath(@__DIR__, "..", "src_js", "plutoplotlyplot.js"), String)

"""
Expand All @@ -72,9 +71,7 @@ function Base.show(io::IO, ::Union{MIME"text/html", MIME"juliavscode/html"}, p::
# so we can't create a plot and update it in the cell with the draing commands
if !p.update
result="""
<script>
$(plotly)
</script>
<script src="https://cdn.plot.ly/plotly-2.18.2.min.js"> </script>
<div id="$(p.uuid)" style= "width: $(p.w)px; height: $(p.h)px; ; display: inline-block;style="white-space:nowrap;"></div>
"""*result
end
Expand Down
5 changes: 1 addition & 4 deletions src/plutovtkplot.jl
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,6 @@ function PlutoVTKPlot(;resolution=(300,300), kwargs...)
p
end

const vtk = read(joinpath(@__DIR__, "..", "imports", "vtk.js"), String)
const canvascolorbar = read(joinpath(@__DIR__, "..", "src_js", "canvascolorbar.js"), String)
const plutovtkplot = read(joinpath(@__DIR__, "..", "src_js", "plutovtkplot.js"), String)

Expand All @@ -70,9 +69,7 @@ function Base.show(io::IO, ::MIME"text/html", p::PlutoVTKPlot)
div=""
if !p.update
div="""
<script>
$(vtk)
</script>
<script src="https://cdn.jsdelivr.net/npm/vtk.js@25.15.1/vtk.js"></script>
<div style="white-space:nowrap;">
<div id="$(p.uuid)" style= "width: $(p.w-60)px; height: $(p.h-60)px; display: inline-block; "></div>
<canvas id="$(uuidcbar)" width=60, height="$(p.h-25)" style="display: inline-block; "></canvas>
Expand Down

2 comments on commit 0ad46f4

@j-fu
Copy link
Owner Author

@j-fu j-fu commented on 0ad46f4 Feb 26, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JuliaRegistrator
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Registration pull request created: JuliaRegistries/General/78570

After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.

This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:

git tag -a v0.8.24 -m "<description of version>" 0ad46f4cbeb42cdc96fb19e0e2addcb495f03f4d
git push origin v0.8.24

Please sign in to comment.