Skip to content

Commit

Permalink
feat: remove CrashLoggingController.kt
Browse files Browse the repository at this point in the history
  • Loading branch information
jurajhilje committed Aug 13, 2024
1 parent 180443f commit 987f776
Show file tree
Hide file tree
Showing 6 changed files with 0 additions and 90 deletions.
6 changes: 0 additions & 6 deletions core/src/main/java/net/ivpn/core/IVPNApplication.kt
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ import androidx.navigation.NavGraph
import net.ivpn.core.common.FeatureConfig
import net.ivpn.core.common.dagger.ApplicationComponent
import net.ivpn.core.common.dagger.DaggerApplicationComponent
import net.ivpn.core.common.logger.CrashLoggingController
import net.ivpn.core.common.navigation.CustomNavigation
import net.ivpn.core.v2.signup.SignUpController
import net.ivpn.core.v2.updates.UpdatesController
Expand Down Expand Up @@ -42,7 +41,6 @@ object IVPNApplication {
lateinit var updatesController: UpdatesController
lateinit var customNavigation: CustomNavigation
lateinit var moduleNavGraph: NavGraph
lateinit var crashLoggingController: CrashLoggingController
lateinit var config: FeatureConfig

fun initBy(application: Application): ApplicationComponent{
Expand All @@ -67,10 +65,6 @@ object IVPNApplication {
updatesController = controller
}

fun applyCrashController(crashController: CrashLoggingController) {
this.crashLoggingController = crashController
}

fun applyFeatureConfig(config: FeatureConfig) {
this.config = config
}
Expand Down

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,6 @@ public void resetComponents() {
protocolController.reset();
IVPNApplication.updatesController.resetComponent();
logUtil.resetAll();
IVPNApplication.crashLoggingController.reset();
mockLocationController.reset();

NotificationManagerCompat.from(IVPNApplication.application).cancelAll();
Expand Down
2 changes: 0 additions & 2 deletions core/src/main/res/values/strings.xml
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,6 @@
<string name="settings_version">VERSION</string>
<string name="settings_color_theme">Color theme</string>
<string name="settings_enable_logging">Enable logging</string>
<string name="settings_enable_crashes">Enable crash logging</string>
<string name="settings_enable_multi_hop">Multi-hop connection</string>
<string name="settings_multihop_same_provider_title">Multi-hop same provider restriction</string>
<string name="settings_multihop_same_provider_description">Allow to use servers from the same provider to build Multi-hop chain.</string>
Expand All @@ -56,7 +55,6 @@
<string name="settings_send_logs">SEND LOGS</string>
<string name="settings_split_tunneling">Split tunneling</string>
<string name="settings_do_not_collect_your_data">We can\'t see these until you send them to us.</string>
<string name="settings_crash_logging_description">Anonymous crash logs will be sent to IVPN to help us improve the application.</string>
<string name="settings_split_tunneling_description">Choose which apps you want to use with IVPN.</string>
<string name="settings_kill_switch_description">Allow using internet only when IVPN connection is enabled.</string>
<string name="settings_always_on_vpn_description">Can help to improve protection.</string>
Expand Down
10 changes: 0 additions & 10 deletions fdroid/src/main/java/net/ivpn/client/FDroidIVPNApplication.kt
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@ package net.ivpn.client
import androidx.multidex.MultiDexApplication
import net.ivpn.client.dagger.DaggerFDroidComponent
import net.ivpn.client.dagger.FDroidComponent
import net.ivpn.client.logging.StubCrashLoggingController
import net.ivpn.client.navigation.FDroidNavigation
import net.ivpn.client.signup.FDroidSignUpViewModel
import net.ivpn.client.updates.StubUpdatesViewModel
Expand All @@ -44,8 +43,6 @@ class FDroidIVPNApplication: MultiDexApplication() {
@Inject
lateinit var signup: FDroidSignUpViewModel

var crashController = StubCrashLoggingController()

var updates = StubUpdatesViewModel()

override fun onCreate() {
Expand All @@ -55,8 +52,6 @@ class FDroidIVPNApplication: MultiDexApplication() {
initFeatureConfig()
initComponents(appComponent)
initUpdatesController()
//Init crash controller at first
initCrashLogging()
IVPNApplication.initBaseComponents()
initSignUpController()
IVPNApplication.customNavigation = FDroidNavigation()
Expand All @@ -78,9 +73,4 @@ class FDroidIVPNApplication: MultiDexApplication() {
private fun initFeatureConfig() {
IVPNApplication.applyFeatureConfig(FDroidFeatureConfig())
}

private fun initCrashLogging() {
crashController.init()
IVPNApplication.crashLoggingController = crashController
}
}

This file was deleted.

0 comments on commit 987f776

Please sign in to comment.