Delete dangling parentheses.

iterate-ch · Jan 31, 2025 · f5ef9cf · f5ef9cf
1 parent 1e3808c
commit f5ef9cf
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 10 deletions.
diff --git a/osx/src/main/java/ch/cyberduck/ui/cocoa/controller/BrowserController.java b/osx/src/main/java/ch/cyberduck/ui/cocoa/controller/BrowserController.java
@@ -3483,7 +3483,7 @@ public boolean validateMenuItem(final NSMenuItem item) {
                                 final NSArray elements = Rococoa.cast(o, NSArray.class);
                                 if(elements.count().intValue() == 1) {
                                     item.setTitle(MessageFormat.format(LocaleFactory.localizedString(title),
-                                            "\"" + elements.objectAtIndex(new NSUInteger(0)) + "\"").trim());
+                                            String.format("\"%s\"", elements.objectAtIndex(new NSUInteger(0)))).trim());
                                 }
                                 else {
                                     item.setTitle(MessageFormat.format(LocaleFactory.localizedString(title),
@@ -3498,7 +3498,7 @@ public boolean validateMenuItem(final NSMenuItem item) {
                 else {
                     if(pasteboard.size() == 1) {
                         item.setTitle(MessageFormat.format(LocaleFactory.localizedString(title),
-                                "\"" + pasteboard.get(0).getName() + "\"").trim());
+                                String.format("\"%s\"", pasteboard.get(0).getName())).trim());
                     }
                     else {
                         item.setTitle(MessageFormat.format(LocaleFactory.localizedString(title),
@@ -3508,13 +3508,7 @@ public boolean validateMenuItem(final NSMenuItem item) {
             }
         }
         else if(action.equals(Foundation.selector("cut:")) || action.equals(Foundation.selector("copy:"))) {
-            String title = null;
-            if(action.equals(Foundation.selector("cut:"))) {
-                title = "Cut {0}";
-            }
-            else if(action.equals(Foundation.selector("copy:"))) {
-                title = "Copy {0}";
-            }
+            final String title = action.equals(Foundation.selector("cut:")) ? "Cut {0}" : "Copy {0}";
             if(this.isMounted()) {
                 int count = this.getSelectionCount();
                 if(0 == count) {

diff --git a/osx/src/main/java/ch/cyberduck/ui/cocoa/controller/TransferController.java b/osx/src/main/java/ch/cyberduck/ui/cocoa/controller/TransferController.java
@@ -842,7 +842,7 @@ public boolean validateMenuItem(final NSMenuItem item) {
                     }
                     else {
                         item.setTitle(MessageFormat.format(LocaleFactory.localizedString("Paste {0}"),
-                            MessageFormat.format(LocaleFactory.localizedString("{0} Items"), String.valueOf(pasteboard.size())) + ")"));
+                                MessageFormat.format(LocaleFactory.localizedString("{0} Items"), String.valueOf(pasteboard.size()))));
                     }
                 }
             }
-Original file line number
+Diff line change
@@ Expand Up / @@ -842,7 +842,7 @@ public boolean validateMenuItem(final NSMenuItem item) { @@
                         }
                         else {
                             item.setTitle(MessageFormat.format(LocaleFactory.localizedString("Paste {0}"),
-                                MessageFormat.format(LocaleFactory.localizedString("{0} Items"), String.valueOf(pasteboard.size())) + ")"));
+                                    MessageFormat.format(LocaleFactory.localizedString("{0} Items"), String.valueOf(pasteboard.size()))));
                         }
                     }
                 }
@@ Expand Down @@