Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug caused by my previous fix 😅 #374

Open
mikyll opened this issue Sep 16, 2023 · 2 comments
Open

Bug caused by my previous fix 😅 #374

mikyll opened this issue Sep 16, 2023 · 2 comments
Assignees
Labels
bug Something isn't working todo

Comments

@mikyll
Copy link
Contributor

mikyll commented Sep 16, 2023

Describe the bug
The website now shows the escape characters introduced by feature #361 (when I implemented it I didn't think of that 😓)

Possible solution

  • automatically remove the escape characters when building the cards in the web view;
  • build the web view from the json files;

Screenshots
image

image

image

@mikyll mikyll added the bug Something isn't working label Sep 16, 2023
@edoardocostantinidev
Copy link
Collaborator

@alessandromr I was under the impression the webview was built from the JSON files

@alessandromr
Copy link
Member

The web view is indeed built using the JSON file as the source of truth. I think the issue is with escaping on the web view side, let me have a look at it.
It will probably take some days because I'm cleaning up the web view and so this will be fixed in that batch of changes.

@alessandromr alessandromr self-assigned this Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working todo
Projects
None yet
Development

No branches or pull requests

3 participants