Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: fix istiooperator upgrade guide #16262

Merged
merged 3 commits into from
Feb 25, 2025
Merged

docs: fix istiooperator upgrade guide #16262

merged 3 commits into from
Feb 25, 2025
+6 −2

Conversation

dotdc
Copy link
Contributor

@dotdc dotdc commented Feb 21, 2025

Description

Changes:

  • Added command to convert IstioOperator YAML file to Helm values
  • Added missing output argument for istioctl migration

Reviewers

  • Ambient
  • Docs
  • Installation
  • Networking
  • Performance and Scalability
  • Extensions and Telemetry
  • Security
  • Test and Release
  • User Experience
  • Developer Infrastructure
  • Localization/Translation

@dotdc dotdc requested a review from a team as a code owner February 21, 2025 20:35
@istio-testing istio-testing added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 21, 2025
@istio-testing
Copy link
Contributor

Hi @dotdc. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Arhell
Arhell reviewed Feb 22, 2025
View reviewed changes
Copy link
Member

@Arhell Arhell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

@istio-testing istio-testing added ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. and removed needs-ok-to-test labels Feb 22, 2025
@dotdc
docs: fix istio operator upgrade guide
988ec3d 
Signed-off-by: David Calvert <david@0xdc.me>
@dotdc
Copy link
Contributor Author

dotdc commented Feb 22, 2025

Fixed lint issue

@dotdc dotdc requested a review from Arhell February 24, 2025 14:51
@dotdc @bleggett
Update content/en/blog/2024/in-cluster-operator-deprecation-announcem…
0d88f0e 
…ent/index.md

Co-authored-by: Ben Leggett <854255+bleggett@users.noreply.github.com>
@dotdc dotdc requested a review from bleggett February 25, 2025 06:47
@dotdc @craigbox
Update content/en/blog/2024/in-cluster-operator-deprecation-announcem…
0e50925 
…ent/index.md

Co-authored-by: Craig Box <craig.box@gmail.com>
@dotdc dotdc requested a review from craigbox February 25, 2025 09:47
@craigbox craigbox added the cherrypick/release-1.24 Set this label on a PR to auto-merge it to the release-1.24 branch label Feb 25, 2025
@istio-testing istio-testing merged commit ed2b596 into istio:master Feb 25, 2025
6 checks passed
wilsonwu added a commit to wilsonwu/istio.io that referenced this pull request Feb 26, 2025
@wilsonwu
Sync istio#16262 istiooperator upgrade guide fix into Chinese
ddf4476
@wilsonwu wilsonwu mentioned this pull request Feb 26, 2025
Open
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@craigbox craigbox craigbox approved these changes

@Arhell Arhell Awaiting requested review from Arhell

@bleggett bleggett Awaiting requested review from bleggett

Assignees
No one assigned
Labels
cherrypick/release-1.24 Set this label on a PR to auto-merge it to the release-1.24 branch kind/docs ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@dotdc @istio-testing @craigbox @bleggett @Arhell @istio-policy-bot