Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update UPSTREAM_CLUSTER to UPSTREAM_CLUSTER_RAW #16252

Merged
merged 2 commits into from
Feb 19, 2025
Merged

Update UPSTREAM_CLUSTER to UPSTREAM_CLUSTER_RAW #16252

merged 2 commits into from
Feb 19, 2025

Conversation

goku321
Copy link
Contributor

@goku321 goku321 commented Feb 16, 2025

Description

Istio default access log format was updated to use UPSTREAM_CLUSTER_RAW instead of UPSTREAM_CLUSTER. Updating the doc to reflect the same.

Reviewers

  • Ambient
  • Docs
  • Installation
  • Networking
  • Performance and Scalability
  • Extensions and Telemetry
  • Security
  • Test and Release
  • User Experience
  • Developer Infrastructure
  • Localization/Translation

@goku321 goku321 requested a review from a team as a code owner February 16, 2025 19:30
@istio-testing istio-testing added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. needs-ok-to-test labels Feb 16, 2025
@istio-testing
Copy link
Contributor

Hi @goku321. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@goku321 goku321 mentioned this pull request Feb 16, 2025
Closed
11 tasks
Arhell
Arhell reviewed Feb 17, 2025
View reviewed changes
Copy link
Member

@Arhell Arhell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

@istio-testing istio-testing added ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. and removed needs-ok-to-test labels Feb 17, 2025
@istio-testing istio-testing merged commit 01b9b54 into istio:master Feb 19, 2025
13 checks passed
wilsonwu added a commit to wilsonwu/istio.io that referenced this pull request Feb 20, 2025
@wilsonwu
Sync istio#16252 Update UPSTREAM_CLUSTER to UPSTREAM_CLUSTER_RAW into…
176e47b 
… Chinese
@wilsonwu wilsonwu mentioned this pull request Feb 20, 2025
Merged
11 tasks
@goku321 goku321 deleted the patch-doc branch February 20, 2025 05:11
istio-testing pushed a commit that referenced this pull request Feb 20, 2025
@wilsonwu
Sync #16252 Update UPSTREAM_CLUSTER to UPSTREAM_CLUSTER_RAW into Chin…
915bf07 
…ese (#16259)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Arhell Arhell Arhell left review comments

@craigbox craigbox craigbox approved these changes

@keithmattix keithmattix keithmattix approved these changes

Assignees
No one assigned
Labels
kind/docs ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@goku321 @istio-testing @craigbox @keithmattix @Arhell @istio-policy-bot