Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

envoy file provider support omit_empty_values #3426

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

zirain
Copy link
Member

@zirain zirain commented Jan 31, 2025

@zirain zirain requested a review from a team as a code owner January 31, 2025 14:04
@istio-testing istio-testing added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 31, 2025
@zirain zirain added the release-notes-none Indicates a PR that does not require release notes. label Feb 2, 2025
@zirain
Copy link
Member Author

zirain commented Feb 2, 2025

/test release-notes

@zirain zirain changed the title envoy file provider support envoy file provider support omit_empty_values Feb 2, 2025
// Optional. If set to true, when command operators are evaluated to null,
// For text format, the output of the empty operator is changed from “-“ to an empty string.
// For json format, the keys with null values are omitted in the output structure.
bool omit_empty_values = 3;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

by default is it is empty, isn't it difficult to distinguish which field is empty?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for text, yes.
but it's useful for json.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes-none Indicates a PR that does not require release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants