Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use rsync to copy tbb libs to avoid relinking every time running make #7155

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

cielavenir
Copy link
Contributor

Type

  • Bug fix (non-breaking change which fixes an issue): Fixes Open3D 0.19.0 "make install" causes relink #7152
  • New feature (non-breaking change which adds functionality). Resolves #
  • Breaking change (fix or feature that would cause existing functionality to not work as expected) Resolves #

Motivation and Context

cmake -E copy_directory copies the directory unconditionally without keeping timestamp. Then make thinks that libippc*_tl_tbb.a is updated and needs relinking libOpen3D.so.

In this MR we will use rsync -rut to avoid unnecessary updating.

Checklist:

  • I have run python util/check_style.py --apply to apply Open3D code style
    to my code.
  • This PR changes Open3D behavior or adds new functionality.
    • Both C++ (Doxygen) and Python (Sphinx / Google style) documentation is
      updated accordingly.
    • I have added or updated C++ and / or Python unit tests OR included test
      results
      (e.g. screenshots or numbers) here.
  • I will follow up and update the code if CI fails.
  • For fork PRs, I have selected Allow edits from maintainers.

Description

Copy link

update-docs bot commented Jan 31, 2025

Thanks for submitting this pull request! The maintainers of this repository would appreciate if you could update the CHANGELOG.md based on your changes.

@cielavenir
Copy link
Contributor Author

cielavenir commented Jan 31, 2025

oh... it is super-sad that Open3D build agent does not have rsync, I thought it should be standard package...

do you mind telling me how this PR can be improved?

[edit] yeah, so the CI passes on MacOS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Open3D 0.19.0 "make install" causes relink
1 participant