-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make plane segmentation from point cloud deterministic #6580
Conversation
this changes makes the results deterministic when a seed is used
Thanks for submitting this pull request! The maintainers of this repository would appreciate if you could update the CHANGELOG.md based on your changes. |
Thanks @jkuck ! Updated title of PR. |
Thanks for updating the title @ssheorey! Would you please help me fix the failing style check? |
Hi @jkuck, please check the style guide: https://www.open3d.org/docs/release/contribute/styleguide.html |
Thanks @yuecideng! I fixed the formatting using your instructions. |
@ssheorey, @yuecideng it looks like we are waiting on workflows to complete before merging. Do you know what needs to be done to kick the workflows off? Thanks. |
@ssheorey I see that all checks have passed now. Are we waiting on anything else to merge? |
Thanks @jkuck ! Merged. |
Thank you! |
This change makes the results deterministic when a random seed is set.
Type
Motivation and Context
Checklist:
python util/check_style.py --apply
to apply Open3D code styleto my code.
updated accordingly.
results (e.g. screenshots or numbers) here.
Description