Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make plane segmentation from point cloud deterministic #6580

Merged
merged 3 commits into from
Feb 6, 2024

Conversation

jkuck
Copy link
Contributor

@jkuck jkuck commented Jan 8, 2024

This change makes the results deterministic when a random seed is set.

Type

  • Bug fix (non-breaking change which fixes an issue): Fixes #
  • New feature (non-breaking change which adds functionality). Resolves #
  • Breaking change (fix or feature that would cause existing functionality to not work as expected) Resolves #

Motivation and Context

Checklist:

  • I have run python util/check_style.py --apply to apply Open3D code style
    to my code.
  • This PR changes Open3D behavior or adds new functionality.
    • Both C++ (Doxygen) and Python (Sphinx / Google style) documentation is
      updated accordingly.
    • I have added or updated C++ and / or Python unit tests OR included test
      results
      (e.g. screenshots or numbers) here.
  • I will follow up and update the code if CI fails.
  • For fork PRs, I have selected Allow edits from maintainers.

Description

this changes makes the results deterministic when a seed is used
Copy link

update-docs bot commented Jan 8, 2024

Thanks for submitting this pull request! The maintainers of this repository would appreciate if you could update the CHANGELOG.md based on your changes.

@ssheorey
Copy link
Member

ssheorey commented Jan 19, 2024

Thanks @jkuck !

Updated title of PR.

@ssheorey ssheorey changed the title feat: move RANSAC sampling outside parallel for loop Make plane segmentation from point cloud deterministic Jan 19, 2024
@jkuck
Copy link
Contributor Author

jkuck commented Jan 23, 2024

Thanks for updating the title @ssheorey! Would you please help me fix the failing style check?

@yuecideng
Copy link
Collaborator

Hi @jkuck, please check the style guide: https://www.open3d.org/docs/release/contribute/styleguide.html

@jkuck
Copy link
Contributor Author

jkuck commented Jan 30, 2024

Thanks @yuecideng! I fixed the formatting using your instructions.

@jkuck
Copy link
Contributor Author

jkuck commented Jan 30, 2024

@ssheorey, @yuecideng it looks like we are waiting on workflows to complete before merging. Do you know what needs to be done to kick the workflows off? Thanks.

@jkuck
Copy link
Contributor Author

jkuck commented Feb 6, 2024

@ssheorey I see that all checks have passed now. Are we waiting on anything else to merge?

@ssheorey ssheorey merged commit 2e47a12 into isl-org:main Feb 6, 2024
36 checks passed
@ssheorey
Copy link
Member

ssheorey commented Feb 6, 2024

Thanks @jkuck ! Merged.

@jkuck
Copy link
Contributor Author

jkuck commented Feb 6, 2024

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants