[fix]pass code style check

isl-org · Jan 29, 2025 · 46ee00f · 46ee00f
1 parent caa6d8c
commit 46ee00f
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 36 deletions.
diff --git a/cpp/open3d/ml/paddle/misc/VoxelPoolingOpKernel.cpp b/cpp/open3d/ml/paddle/misc/VoxelPoolingOpKernel.cpp
@@ -16,7 +16,7 @@ namespace {
 template <class TReal, class TFeat>
 class OutputAllocator {
 public:
-    OutputAllocator(paddle::Place place) : place(place) {}
+    explicit OutputAllocator(paddle::Place place) : place(place) {}
 
     void AllocPooledPositions(TReal** ptr, size_t num) {
         if (num != 0) {

diff --git a/python/open3d/ml/paddle/python/layers/convolutions.py b/python/open3d/ml/paddle/python/layers/convolutions.py
@@ -251,7 +251,6 @@ def forward(self,
             inp_importance = paddle.empty(
                 (0,), dtype=paddle.float32).to(self.kernel.place)
 
-        return_distances = not self.window_function is None
 
         if not user_neighbors_index is None and not user_neighbors_row_splits is None:
 
@@ -272,12 +271,6 @@ def forward(self,
                     queries=out_positions,
                     radius=radius,
                     hash_table=fixed_radius_search_hash_table)
-                if return_distances:
-                    if self.radius_search_metric == 'L2':
-                        neighbors_distance_normalized = self.nns.neighbors_distance / (
-                            radius * radius)
-                    else:  # L1
-                        neighbors_distance_normalized = self.nns.neighbors_distance / radius
 
             elif len(extents.shape) == 1:
                 radii = 0.5 * extents
@@ -291,6 +284,12 @@ def forward(self,
             if self.window_function is None:
                 neighbors_importance = paddle.empty((0,), dtype=paddle.float32)
             else:
+                if self.radius_search_metric == 'L2':
+                    neighbors_distance_normalized = self.nns.neighbors_distance / (
+                        radius * radius)
+                else:  # L1
+                    neighbors_distance_normalized = self.nns.neighbors_distance / radius
+
                 neighbors_importance = self.window_function(
                     neighbors_distance_normalized)
 

diff --git a/util/ci_utils.sh b/util/ci_utils.sh
@@ -96,7 +96,7 @@ install_python_dependencies() {
     if [ "$BUILD_PADDLE_OPS" == "ON" ]; then # ML/requirements-torch.txt
         if [[ "$OSTYPE" == "linux-gnu"* ]]; then
             python -m pip uninstall paddlepaddle paddlepaddle-gpu -y
-            python -m pip install --pre $PADDLE_GLNX -i $PADDLE_GLNX_PIP_INDEX
+            python -m pip install --pre "$PADDLE_GLNX" -i "$PADDLE_GLNX_PIP_INDEX"
         else
             echo "unknown OS $OSTYPE"
             exit 1

diff --git a/util/run_python_unittest.sh b/util/run_python_unittest.sh