Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

summary_csv and json validation workflows error on pull request #30

Open
jtcantin opened this issue Nov 20, 2024 · 2 comments
Open

summary_csv and json validation workflows error on pull request #30

jtcantin opened this issue Nov 20, 2024 · 2 comments
Labels
bug Something isn't working low priority

Comments

@jtcantin
Copy link
Contributor

When making a pull request but before it is accepted, Github runs both the csv summary and json validation workflows. They seem to error out even if the problem instances pass validation after merging. That is, the json validation workflow executes properly once the PR is accepted/merged, but not at pre-acceptance time.

For csv summary, one issue is just compatibility with the new schema (I'll start a separate issue for this).

Though, the json validation workflow errors out when it attempts to commit. That is, it seems the workflow is trying to commit within the "workflow action virtual machine", but receives the error that it is not on a branch. See attached screenshots from PR #29

The csv summary workflow also involves a commit, so I presume it would error out at that point as well.

I think one simple fix would be to have two separate workflows for each; one for merging, and one for pull requests.

image

image

@jtcantin jtcantin added bug Something isn't working low priority labels Nov 20, 2024
@jtcantin
Copy link
Contributor Author

Low priority as this fix is just needed for the future, not by the next deadline.

@jp7745
Copy link
Member

jp7745 commented Dec 18, 2024

temporarily disabled github actions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working low priority
Projects
None yet
Development

No branches or pull requests

2 participants