Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update fatlum.is-cool.me.json #193

Merged
merged 3 commits into from
Jan 7, 2025
Merged

Conversation

ghost
Copy link

@ghost ghost commented Jan 7, 2025

No description provided.

@ghost ghost self-requested a review as a code owner January 7, 2025 15:13
@github-actions github-actions bot added the domain label Jan 7, 2025
@is-cool-me is-cool-me bot enabled auto-merge January 7, 2025 15:14
Copy link
Contributor

is-cool-me bot commented Jan 7, 2025

Review by is-cool-me copilot

@fatlum, thank you for contributing to the project! 🎉

Review Comments

I noticed that you've made changes to the fatlum.is-cool.me.json file. The diff shows you've removed two TXT records:

  1. An AT Protocol DID record
  2. A Discord verification record

Observations

  • The changes appear to remove previously configured DNS records
  • The CNAME record pointing to itsfatlum.github.io remains unchanged

Questions

  • Was the removal of these records intentional?
  • Do you still want to maintain these DNS configurations?

Recommendation

  • If these records were removed by mistake, please restore them
  • If they were intentionally removed, please provide context in the PR description

Suggestion

Consider adding a brief description explaining the purpose of these changes to help reviewers understand your intent.


Would you like to provide more details about this update? 👀

Cheers! 🚀

auto-merge was automatically disabled January 7, 2025 15:18

Head branch was pushed to by a user without write access

@is-cool-me is-cool-me bot enabled auto-merge January 7, 2025 15:18
auto-merge was automatically disabled January 7, 2025 15:24

Head branch was pushed to by a user without write access

@is-cool-me is-cool-me bot enabled auto-merge January 7, 2025 15:24
@is-cool-me is-cool-me bot merged commit 95af1a0 into is-cool-me:main Jan 7, 2025
7 checks passed
@is-cool-me is-cool-me locked and limited conversation to collaborators Jan 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants