Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create itsfsmp.is-cool.me.json #190

Merged
merged 5 commits into from
Dec 14, 2024
Merged

Conversation

ghost
Copy link

@ghost ghost commented Dec 6, 2024

No description provided.

@ghost ghost requested a review from LightHostingFree as a code owner December 6, 2024 17:23
@is-cool-me is-cool-me bot enabled auto-merge December 6, 2024 17:23
Copy link
Contributor

is-cool-me bot commented Dec 6, 2024

Pull Request Review

Hello Fatlum,

Thank you for contributing to the project!

Summary

The file itsfatlumsmp.is-cool.me.json has been added, which contains configuration for the subdomain itsfatlumsmp.is-cool.me. This configuration includes a CNAME record pointing to itsfatlumsmp.github.io.

Review

  • The JSON structure looks clean and properly formatted.
  • The record type CNAME is correctly defined, pointing to the intended GitHub Pages URL: itsfatlumsmp.github.io.
  • The proxied field is set to false, which seems appropriate for this setup.
  • It's good that you've included the owner object with the username itsFatlum, though the email field is empty. If there's no specific need for an email, this is fine, but it might be worth considering removing the empty field or adding one if it's necessary for documentation or future use.

Suggestions

  • If you decide to add an email to the owner object, make sure it follows the proper format for clarity.

Overall, this is a solid addition, and everything seems to be in order!

Thanks again for your contribution!

Best regards,
is-cool-me copilot

auto-merge was automatically disabled December 6, 2024 21:19

Head branch was pushed to by a user without write access

@ghost ghost changed the title Create itsfatlumsmp.is-cool.me.json Create itsfsmp.is-cool.me.json Dec 6, 2024
@is-cool-me is-cool-me bot enabled auto-merge December 6, 2024 21:19
Copy link
Collaborator

@LightHostingFree LightHostingFree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bro you have to add file in domains folder not in root

@ghost
Copy link
Author

ghost commented Dec 7, 2024

That was actually a mistake. I thought I added the file to the domains folder.

auto-merge was automatically disabled December 7, 2024 16:54

Head branch was pushed to by a user without write access

@is-cool-me is-cool-me bot enabled auto-merge December 7, 2024 16:54
auto-merge was automatically disabled December 7, 2024 16:54

Head branch was pushed to by a user without write access

@ghost ghost self-requested a review as a code owner December 7, 2024 16:54
@is-cool-me is-cool-me bot enabled auto-merge December 7, 2024 16:54
@github-actions github-actions bot added the domain label Dec 7, 2024
@is-cool-me is-cool-me bot merged commit 8c87941 into is-cool-me:main Dec 14, 2024
7 checks passed
@is-cool-me is-cool-me locked and limited conversation to collaborators Dec 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants