Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update domains #152

Merged
merged 2 commits into from
Aug 25, 2024
Merged

Update domains #152

merged 2 commits into from
Aug 25, 2024

Conversation

ShadowGaming100
Copy link
Contributor

Requirements

  • You have completed your website.
  • The website is reachable.
  • The CNAME record doesn't contain https:// or /.
  • There is sufficient information at the owner field.

Description

Domains will be used for my GitHub’s website and for my techs and projects

Link to Website

@ShadowGaming100 ShadowGaming100 requested a review from a team as a code owner August 25, 2024 21:35
@is-cool-me is-cool-me bot enabled auto-merge August 25, 2024 21:35
Copy link
Contributor

is-cool-me bot commented Aug 25, 2024

# Pull Request Review for "Update domains"

**Author:** Shadow Gaming

---

### Thank you for contributing to the project!

Your addition of the domain configurations is clear and well-structured. Here's a quick review:

#### Changes Overview  
- You've added two new domain JSON files:
  - `codelabworks.is-app.tech.json`
  - `shadow-gaming.is-cool.me.json`

#### Review Feedback  
1. **Clarity of Information**: 
   - The inclusion of the `owner` field with the username is great for accountability.
   
2. **CNAME Record Consideration**:
   - I see that you’ve adhered to the requirement about the CNAME record not containing `https://` or `/`, which is excellent.

3. **NS Records**:
   - The NS records are consistent and well-defined. If you plan to add more domains in the future, consider documenting any variations in NS records for clarity.

4. **Proxied Setting**:
   - Setting `proxied` to false is appropriate if you're not using Cloudflare’s proxy service. Just a note to ensure this aligns with your desired performance and security settings.

### Suggestions  
- Consider adding a brief description in each JSON file to explain the purpose of the domain. This can help future contributors understand the context quickly.

Overall, great job on this pull request! It’s clear you’ve put effort into ensuring everything meets the requirements. Looking forward to seeing your website in action!

---

**Merge Recommendation**: ✅ Approved for merge.

@is-cool-me is-cool-me bot merged commit a6ef96a into is-cool-me:main Aug 25, 2024
8 checks passed
@is-cool-me is-cool-me locked and limited conversation to collaborators Aug 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants