Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Emit hook when journal is ready. #728

Open
ThreeHats opened this issue Oct 25, 2024 · 0 comments
Open

[Feature Request] Emit hook when journal is ready. #728

ThreeHats opened this issue Oct 25, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@ThreeHats
Copy link

Feature request:
Currently, there's no reliable way to determine when the Enhanced Journal is fully loaded and ready for interaction, which leads to timing issues when trying to modify or interact with the journal content.

For context, I'm updating the module gm-notes to display the gm note below the page content. The module also adds a header button that is styled depending on whether there is a gm note attached to the currently viewed page. It can take some time to load the page (especially for large 1000+ page journals), so I've ended up adding a 5 second delay before adding or updating the header button for Enhanced Journal.

Would you consider adding a new hook that fires when the Enhanced Journal is fully loaded and ready? This would be incredibly helpful for module developers who need to perform actions or modifications once the journal is completely rendered and functional.

Suggested Implementation:
A hook named something like monksEnhancedJournalReady that fires after the journal is fully loaded, including all pages and content, passing the app in the hook.

For example:
Hooks.callAll('monksEnhancedJournalReady', this);

@ThreeHats ThreeHats added the enhancement New feature or request label Oct 25, 2024
@ThreeHats ThreeHats changed the title [Feature request] Emit hook when journal is ready. [Feature Request] Emit hook when journal is ready. Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant