[BUG] Conflicts with kanka-Foundry

[eXaminator]

Hi, I'm the maintainer of the Kanka-Foundry module (https://github.com/eXaminator/kanka-foundry).

I received a conflict bug (eXaminator/kanka-foundry#140) but was able to trace it back to your module.

It seems that you - for some reason - make a copy of foundries JournalEntryPage dataTypes using foundry.utils.mergeObject(). The problem here is, that this function seems to handle object property keys with points in them (like kanka-foundry.abilities) by creating nested objects (like { 'kanka-foundry': { 'abilities': ... } }). Once this happens, it breaks other stuff in foundry down the line as foundry expects dataTypes to be a simple (flat) key-value map of schemas.

Here's the line:

monks-enhanced-journal/monks-enhanced-journal.js

Line 2113 in a811fcd

CONFIG.JournalEntryPage.dataModels = foundry.utils.mergeObject((CONFIG.JournalEntryPage.dataModels || {}), {});

Is there a specific reason for this call? Could it be done another way as to prevent breaking other modules that use dots no namespace their dataType names?

Thanks!

[Nedrapter]

I've been a victim of this conflict and it makes the world not able to load anymore! Please fix! I love both modules!

[eXaminator]

Given that there seem to be at least 3 instances of this bug creeping up by now and the issue has had the "fixed waiting release" tag for over 2 months now, is there something specific blocking this release? Seeing as this is a bug actually blocking people from even entering their world without safe mode it would be great if a fix for this could be released :)