Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix LoadBalancer port protocol assignment #415

Merged
merged 1 commit into from
May 1, 2024

Conversation

ushabelgur
Copy link
Contributor

Proposed Changes

  • The update modifies the way the protocol of each LoadBalancerPort is assigned. Instead of directly referencing the service's port protocol, a new variable is created for it. This change improves code clarity and helps avoid unexpected behavior due to mutable references.

Fixes #

@ushabelgur ushabelgur requested a review from a team as a code owner April 29, 2024 11:19
@github-actions github-actions bot added size/XS bug Something isn't working labels Apr 29, 2024
@ushabelgur ushabelgur force-pushed the fix/port_protocol_assignment branch from be9b778 to 972df2f Compare April 29, 2024 11:46
@afritzler afritzler merged commit 3941fad into main May 1, 2024
9 checks passed
@afritzler afritzler deleted the fix/port_protocol_assignment branch May 1, 2024 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants