Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[21] add Koutheir's pretty printers for STL in libcxx #22

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

d-w-moore
Copy link
Contributor

No description provided.

@d-w-moore d-w-moore marked this pull request as draft January 3, 2021 22:10
@trel
Copy link
Member

trel commented Jan 3, 2021

can we parameterize the script a bit - or pick up the clang and cmake versions from somewhere else? I feel this will perhaps grow stale and forgotten...

@d-w-moore
Copy link
Contributor Author

Agreed, maybe collect these parameters into defaults (as environment variables overrideable via arguments) near head of script. It's not too hard to compute latest version of cmake in externals. And relevant commit for pretty printers will have to be a function of the clang / libcxx version.

@@ -0,0 +1,125 @@
#!/bin/bash

if [ ${CHK-1} ] ; then
Copy link
Contributor Author

@d-w-moore d-w-moore Jan 6, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to remove this 'if' when done with troubleshooting

fi

echo >&2 -e "\n--> Creating $HOME/.gdbinit for gdb and rr.\n"
cd ~ ; git clone https://github.com/koutheir/libcxx-pretty-printers
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we clone this repository into the irods namespace? we do this for most everything else we use...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think so. Clone away, and I will change the reference.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants