-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[21] add Koutheir's pretty printers for STL in libcxx #22
base: main
Are you sure you want to change the base?
Conversation
can we parameterize the script a bit - or pick up the clang and cmake versions from somewhere else? I feel this will perhaps grow stale and forgotten... |
Agreed, maybe collect these parameters into defaults (as environment variables overrideable via arguments) near head of script. It's not too hard to compute latest version of cmake in externals. And relevant commit for pretty printers will have to be a function of the clang / libcxx version. |
koutheir-pretty-printers.sh
Outdated
@@ -0,0 +1,125 @@ | |||
#!/bin/bash | |||
|
|||
if [ ${CHK-1} ] ; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to remove this 'if' when done with troubleshooting
fi | ||
|
||
echo >&2 -e "\n--> Creating $HOME/.gdbinit for gdb and rr.\n" | ||
cd ~ ; git clone https://github.com/koutheir/libcxx-pretty-printers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we clone this repository into the irods namespace? we do this for most everything else we use...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think so. Clone away, and I will change the reference.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
now available at https://github.com/irods/libcxx-pretty-printers
No description provided.