Fix auto update error handling

irccloud · May 24, 2019 · 6651632 · 6651632
1 parent 6abfedb
commit 6651632
Showing 1 changed file with 6 additions and 7 deletions.
diff --git a/app/auto_update.js b/app/auto_update.js
@@ -37,11 +37,9 @@ module.exports = {
     autoUpdater.allowPrerelease = true;
     autoUpdater.fullChangelog = true;
 
-    try {
-      autoUpdater.checkForUpdates();
-    } catch (exc) {
-      // This will error if running with code signing
-    }
+    autoUpdater.checkForUpdates().catch(function (exc) {
+      // pass
+    });
 
     autoUpdater.on('error', function (error, errorMessage) {
       setUpdateCheckMenuEnabled(menu, true);
@@ -66,7 +64,9 @@ module.exports = {
   check: function () {
     if (autoUpdater) {
       // TODO show progress dialog
-      autoUpdater.checkForUpdates();
+      autoUpdater.checkForUpdates().catch(function (exc) {
+        // pass
+      });
       autoUpdater.once('error', onUpdateError);
       autoUpdater.once('update-downloaded', onUpdateDownloaded);
       autoUpdater.once('update-not-available', onUpdateNotAvailable);
@@ -149,7 +149,6 @@ function onUpdateNotAvailable (event) {
   autoUpdater.removeListener('update-downloaded', onUpdateDownloaded);
 }
 function onUpdateError (error, errorMessage) {
-  log.error('updateError', errorMessage, error);
   dialog.showMessageBox({
     type: 'error',
     message: 'Error checking for updates',