Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update determination of iraf and IRAFARCH variables #171

Merged
merged 1 commit into from
Jun 13, 2024
Merged

Conversation

olebole
Copy link
Member

@olebole olebole commented Jun 4, 2024

These variables are now retrieved from the configuration for the different IRAF architectures instead of from /usr/local/bin/cl.

The problems here were that

  • /usr/local/bin/cl does not necessarily exist (maybe irafcl, or at different locations)
  • the structure of this file changed, there is no longer a unconditional exec statement at the end

Also, there are better ways to find out the iraf variable, which are all tested here:

  • Community IRAF puts the IRAF path in ~/.iraf/irafroot resp. /etc/iraf/irafroot,
  • personal installations of NOAO and NOIRLab IRAF have an export iraf=/..." statement in ~/.iraf/setup.sh`,
  • system installation of NOAO IRAF uses a define in /usr/include/iraf.h for this,
  • There a a number of pre-defined ways, like /usr/lib/iraf/, /usr/local/lib/iraf/, /opt/iraf/, /iraf/iraf/ and others

Similarly, to determine IRAFARCH (if not set by environment variable):

  • check ~/.iraf/arch (NOAO and NOIRLAB personal installations)
  • check the suffix on the standard IRAF bindir (i.e. iraf$bin.linux64)

Closes: #170

@olebole olebole force-pushed the fix_getIrafEnv branch 6 times, most recently from 43b4ce9 to 6917ecb Compare June 4, 2024 16:02
These variables are now retrieved from the configuration for the
different IRAF architectures instead of from /usr/local/bin/cl.
@olebole olebole merged commit 151350f into main Jun 13, 2024
5 checks passed
@olebole olebole deleted the fix_getIrafEnv branch June 13, 2024 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

IRAF path heuristics buggy for IRAF >= 2.17
1 participant