Add basic tests #5
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
License: MIT Signed-off-by: Vasily Kolobkov <polezaivsani@openmailbox.org>
Kubuxu
reviewed
Nov 16, 2016
|
|
||
| func TestPutCallsGetMeasured(t *testing.T) { | ||
| metrics.InjectImpl(newMockCreator) | ||
| defer metrics.InjectImpl(nil) |
There was a problem hiding this comment.
This won't work as it won't allow you inject new implementation when one is already injected.
I might have to think how to resolve it.
Allowing unregistering the injected creator might not be a bad idea.
There was a problem hiding this comment.
Yeah, i see now. I can call the InjectImpl once upon setup in TestMain ruling it out for the tests. Unregistering would be another option, though i'm unfamiliar with that part of town.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes /issues/4.