Semantic logging #75 #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Neverbolt
force-pushed
the
log_infrastructure
branch
2 times, most recently
from
5edb6f7 to
5b9cc54
Compare
Also changes default value for DbStorage.connection_string fronm ":memory:" to "wintermute.sqlite3"
Neverbolt
force-pushed
the
log_infrastructure
branch
from
8561306 to
17a1d57
Compare
Neverbolt
force-pushed
the
log_infrastructure
branch
from
17a1d57 to
11eeb54
Compare
Neverbolt
force-pushed
the
log_infrastructure
branch
from
b61b820 to
eef144a
Compare
… log_infrastructure
Neverbolt
force-pushed
the
log_infrastructure
branch
from
eef144a to
6eceab6
Compare
andreashappe
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #75
The goal here is to turn the very much ad-hoc and split logging (spread across the log_db and console) into a semantic logging utility.
logbe a global field, so that it doesn't need to be passed around manuallyPosition logging of LLM response streaming better (not sure if that is in the logger yet, the LLM or a third place entirely)Add spinner back inThis adds a web user interface to the application and adapts logging to support a more generic and uniform interface.
The UI server is started using the "Viewer" usecase. Due to lacking capabilities of the configuration management the remote logger needs to be enabler in code for now by changing the last line of logging.py from GlobalLogger = GlobalLocalLogger to GlobalLogger = GlobalRemoteLogger