Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

requests: enhance identity with CommunityInclusionNeed #2537

Merged
merged 2 commits into from
Nov 29, 2023
Merged

requests: enhance identity with CommunityInclusionNeed #2537

merged 2 commits into from
Nov 29, 2023

Conversation

jrcastro2
Copy link
Contributor

@jrcastro2 jrcastro2 commented Nov 16, 2023 •
edited
Loading

slint
slint approved these changes Nov 27, 2023
View reviewed changes
Copy link
Member

@slint slint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for the community inclusion logic, but can't vouch for the JS/UI part (though it looks correct to me :) )

@slint slint merged commit 3693be1 into inveniosoftware:master Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kpsherva kpsherva kpsherva left review comments

@slint slint slint approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jrcastro2 @slint @kpsherva