Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

record details: handle files in pending/failed state #2534

Conversation

anikachurilova
Copy link
Member

all the files are broken:
Screenshot 2023-11-10 at 16 54 07
Screenshot 2023-11-10 at 16 56 45

1/2 file is broken - shows only healthy files
Screenshot 2023-11-10 at 16 56 13

Copy link
Member

@slint slint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments on where/how the filtering should take place.

invenio_app_rdm/requests_ui/views/requests.py Outdated Show resolved Hide resolved
* don't include render of pending/failed files and media files in landing page and in request view
* closes zenodo/rdm-project#471
@anikachurilova anikachurilova force-pushed the broken-preview-when-pending-or-failed-files branch from c107044 to 612b8f9 Compare December 1, 2023 09:27
@slint slint merged commit f00f072 into inveniosoftware:master Dec 4, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants