fix: handle missing force_delete_start date #2758
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update `force_delete_start_date` method to handle cases where `domain.force_delete_start` is not present: - Return formatted current date plus expire warning period if `force_delete_start` is missing - Ensure consistent date formatting across scenarios This change prevents errors when `force_delete_start` is nil and provides a fallback date based on the current date and configured warning period.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update
force_delete_start_datemethod to handle cases wheredomain.force_delete_startis not present:force_delete_startis missingThis change prevents errors when
force_delete_startis nil and provides a fallback date based on the current date and configured warning period.