Skip to content

Commit 840cee3

Browse files
drewdairees
andauthored
updating to DMFR v0.5.0 schema (#275)
* updating to DMFR v0.5.0 schema https://github.com/transitland/distributed-mobility-feed-registry/releases/tag/v0.5.0 * Add description to sqlite, postgres schema --------- Co-authored-by: Ian Rees <ian@ianrees.net>
1 parent 3f44183 commit 840cee3

File tree

7 files changed

+14
-5
lines changed

7 files changed

+14
-5
lines changed

dmfr/registry.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ func ReadRegistry(reader io.Reader) (*Registry, error) {
3838
reg.Operators = loadReg.Operators
3939
reg.Secrets = loadReg.Secrets
4040
if reg.Schema == "" {
41-
reg.Schema = "https://dmfr.transit.land/json-schema/dmfr.schema-v0.4.0.json"
41+
reg.Schema = "https://dmfr.transit.land/json-schema/dmfr.schema-v0.5.0.json"
4242
}
4343
operators := []tl.Operator{}
4444
for _, rfeed := range loadReg.Feeds {

dmfr/registry_test.go

+3-3
Original file line numberDiff line numberDiff line change
@@ -139,17 +139,17 @@ func TestRegistry_Write(t *testing.T) {
139139
{
140140
"feed",
141141
`{"feeds":[{"id":"test","spec":"gtfs"}]}`,
142-
`{"$schema":"https://dmfr.transit.land/json-schema/dmfr.schema-v0.4.0.json","feeds":[{"id":"test","spec":"gtfs"}]}`,
142+
`{"$schema":"https://dmfr.transit.land/json-schema/dmfr.schema-v0.5.0.json","feeds":[{"id":"test","spec":"gtfs"}]}`,
143143
},
144144
{
145145
"feed sorted",
146146
`{"feeds":[{"id":"z","spec":"gtfs"},{"id":"a","spec":"gtfs"}]}`,
147-
`{"$schema":"https://dmfr.transit.land/json-schema/dmfr.schema-v0.4.0.json","feeds":[{"id":"a","spec":"gtfs"},{"id":"z","spec":"gtfs"}]}`,
147+
`{"$schema":"https://dmfr.transit.land/json-schema/dmfr.schema-v0.5.0.json","feeds":[{"id":"a","spec":"gtfs"},{"id":"z","spec":"gtfs"}]}`,
148148
},
149149
{
150150
"nested operators moved to top level",
151151
`{"feeds": [{"id": "z","spec": "gtfs","operators": [{"onestop_id": "o"}]}]}`,
152-
`{"$schema":"https://dmfr.transit.land/json-schema/dmfr.schema-v0.4.0.json","feeds":[{"id":"z","spec":"gtfs"}],"operators":[{"onestop_id":"o","associated_feeds":[{"feed_onestop_id":"z"}]}]}`,
152+
`{"$schema":"https://dmfr.transit.land/json-schema/dmfr.schema-v0.5.0.json","feeds":[{"id":"z","spec":"gtfs"}],"operators":[{"onestop_id":"o","associated_feeds":[{"feed_onestop_id":"z"}]}]}`,
153153
},
154154
}
155155
for _, tc := range tcs {

internal/schema/postgres/migrations/20230708023621_fetch_wait.up.pgsql

+1-1
Original file line numberDiff line numberDiff line change
@@ -2,4 +2,4 @@ BEGIN;
22

33
ALTER TABLE feed_states ADD COLUMN fetch_wait integer;
44

5-
END;
5+
COMMIT;
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
BEGIN;
2+
3+
ALTER TABLE current_feeds ADD COLUMN description text;
4+
5+
COMMIT;

internal/schema/sqlite.sql

+1
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@ CREATE TABLE IF NOT EXISTS "current_feeds" (
1111
"urls" BLOB,
1212
"languages" BLOB,
1313
"name" varchar(255),
14+
"description" varchar(255),
1415
"file" varchar(255) NOT NULL,
1516
"feed_tags" BLOB
1617
);

test/data/server/server-test.dmfr.json

+2
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,8 @@
2525
{
2626
"spec": "gtfs",
2727
"id": "BA",
28+
"name": "BART",
29+
"description": "Bay Area Rapid Transit",
2830
"urls": {
2931
"static_current": "../test/data/external/bart.zip"
3032
}

tl/feed.go

+1
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ type Feed struct {
1414
FeedID string `json:"id" db:"onestop_id"`
1515
SupersedesIDs Strings `json:"supersedes_ids,omitempty" db:"-"`
1616
Name String `json:"name,omitempty"`
17+
Description String `json:"description,omitempty"`
1718
Spec string `json:"spec,omitempty"`
1819
URLs FeedUrls `json:"urls,omitempty" db:"urls"`
1920
Languages FeedLanguages `json:"languages,omitempty"`

0 commit comments

Comments
 (0)