Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(validation): add and improve validation to TracepointCreate.tsx #42

Merged
merged 5 commits into from
Feb 21, 2024

Conversation

Umaaz
Copy link
Member

@Umaaz Umaaz commented Feb 21, 2024

closes #36

What this PR does:

Which issue(s) this PR fixes:
Fixes #

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

@Umaaz Umaaz linked an issue Feb 21, 2024 that may be closed by this pull request
Copy link

github-actions bot commented Feb 21, 2024

Levitate is-compatible report:

🔍 Resolving @grafana/data@latest...
🔍 Resolving @grafana/ui@latest...
🔍 Resolving @grafana/runtime@latest...
🔍 Resolving @grafana/schema@latest...
🔍 Resolving @grafana/e2e-selectors@latest...
🔍 Resolving @grafana/experimental@latest...

🔬 Checking compatibility between ./src/module.ts and @grafana/data@10.3.3...
✔ Found @grafana/data version 10.3.3 locally

🔬 Checking compatibility between ./src/module.ts and @grafana/ui@10.3.3...
✔ Found @grafana/ui version 10.3.3 locally

🔬 Checking compatibility between ./src/module.ts and @grafana/runtime@10.3.3...
✔ Found @grafana/runtime version 10.3.3 locally

🔬 Checking compatibility between ./src/module.ts and @grafana/schema@10.3.3...
✔ Found @grafana/schema version 10.3.3 locally

🔬 Checking compatibility between ./src/module.ts and @grafana/e2e-selectors@10.3.3...
✔ Found @grafana/e2e-selectors version 10.3.3 locally

🔬 Checking compatibility between ./src/module.ts and @grafana/experimental@1.7.10...
✔ Found @grafana/experimental version 1.7.10 locally

✔️ ./src/module.ts appears to be compatible with @grafana/data,@grafana/ui,@grafana/runtime,@grafana/schema,@grafana/e2e-selectors,@grafana/experimental

@Umaaz Umaaz merged commit 04f6b77 into master Feb 21, 2024
3 checks passed
@Umaaz Umaaz deleted the 36-add-validation-to-metric-name-input branch February 21, 2024 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add validation to metric name input
1 participant