Add spec for find all on conversations

intercom · Dec 16, 2022 · e640a2d · e640a2d
1 parent e9ae4b2
commit e640a2d
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/spec/unit/intercom/company_spec.rb b/spec/unit/intercom/company_spec.rb
@@ -9,7 +9,7 @@
       _(proc { client.companies.find(:company_id => "4")}).must_raise Intercom::HttpError
     end
 
-    it "on find_all" do
+    it "on all" do
       client.expects(:get).with("/companies", {}).returns(nil)
       _(proc { client.companies.all.each {|company| }}).must_raise Intercom::HttpError
     end

diff --git a/spec/unit/intercom/conversation_spec.rb b/spec/unit/intercom/conversation_spec.rb
@@ -13,6 +13,11 @@
     client.conversations.all.each { |c| }
   end
 
+  it "can filter conversations based on params" do
+    client.expects(:get).with("/conversations", {type: 'user', intercom_user_id: '123456789'}).returns(test_conversation_list)
+    client.conversations.find_all(type: 'user', intercom_user_id: '123456789').each { |c| }
+  end
+
   it 'marks a conversation as read' do
     client.expects(:put).with('/conversations/147', { read: true })
     client.conversations.mark_read('147')