This repository has been archived by the owner on Aug 20, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 78
Collaborating and Submitting Changes
kalyankondapally edited this page Oct 28, 2014
·
2 revisions
The information next explains how developers and owners can help each other to contribute for the Ozone-Wayland. In general, the contribution process follows the Chromium guidelines (with the exception that we don't have the gcl or git-cl tools).
Submitting pull requests:
- Start a new issue. Add description about the problem and platform. Please do add any relevant bug link (In case your project is using Oz-WL) which has any prior discussions that could help us understand the problem.
- Find an OWNER and discuss whether the issue is valid.
- Branch repository, work on solution.
- When ready for review, add link to your branch in the comments section of issue created in step1.
- Get review from an OWNER, meaning an explicit LGTM. If this is your first contribution, please add your name to AUTHORS list.
- It's quite common that the initial solution is changed during review process. Separate final solution to semantically related commits and send a pull request. Wait for owner to manage the merge.
Coding style:
- Coding style is the same as Chromium's.
Commit message:
- First line should be a summary not exceeding 72 characters.
- Second line should be a blank line.
- Then an explanatory text.
- Unless critical fix, nothing should go into master branch without review from one other OWNER.
- Ensure that latest code always builds.
- Ensure changes don't introduce any new regression and merge pull requests. (hopefully, we are able to soon run chromium tests. This should reduce the burden.)
- Guarantee integrity of whole project together with other owners.