Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Add more Windows hung test checks #16859

Merged
merged 4 commits into from
Feb 3, 2025
Merged

[CI] Add more Windows hung test checks #16859

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
44305ce
[CI] Add more Windows hung test checks
sarnex Jan 31, 2025
e9082f6
newline
sarnex Feb 3, 2025
5b6eb9e
delete the script
sarnex Feb 3, 2025
9ef74a6
prefix shouldnt fail job
sarnex Feb 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions .github/workflows/sycl-windows-build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,13 @@ jobs:
outputs:
build_conclusion: ${{ steps.build.conclusion }}
steps:
- name: Detect hung tests
if: always()
shell: powershell
run: |
Invoke-WebRequest -Uri "https://raw.githubusercontent.com/intel/llvm/refs/heads/sycl/devops/scripts/windows_detect_hung_tests.ps1" -OutFile "windows_detect_hung_tests.ps1"
powershell.exe -File windows_detect_hung_tests.ps1
exit $LASTEXITCODE
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should NOT result in any failure.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couple of points here

  1. the single place we call it today already does
  2. im worried we will never catch hung tests if we dont fail because otherwise the only way to catch it would be to manually read the ci logs

- uses: actions/checkout@v4
with:
sparse-checkout: |
Expand Down Expand Up @@ -182,3 +189,10 @@ jobs:
name: sycl_windows_default
path: ${{ inputs.artifact_archive_name }}
retention-days: ${{ inputs.retention-days }}
- name: Detect hung tests
if: always()
shell: powershell
run: |
Invoke-WebRequest -Uri "https://raw.githubusercontent.com/intel/llvm/refs/heads/sycl/devops/scripts/windows_detect_hung_tests.ps1" -OutFile "windows_detect_hung_tests.ps1"
powershell.exe -File windows_detect_hung_tests.ps1
sarnex marked this conversation as resolved.
Show resolved Hide resolved
exit $LASTEXITCODE
22 changes: 12 additions & 10 deletions .github/workflows/sycl-windows-run-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,13 @@ jobs:
environment: WindowsCILock
env: ${{ fromJSON(inputs.env) }}
steps:
- name: Detect hung tests
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comments apply to this file.

if: always()
shell: powershell
run: |
Invoke-WebRequest -Uri "https://raw.githubusercontent.com/intel/llvm/refs/heads/sycl/devops/scripts/windows_detect_hung_tests.ps1" -OutFile "windows_detect_hung_tests.ps1"
powershell.exe -File windows_detect_hung_tests.ps1
exit $LASTEXITCODE
- uses: actions/checkout@v4
with:
sparse-checkout: |
Expand Down Expand Up @@ -101,18 +108,13 @@ jobs:
fi
export LIT_OPTS="-v --no-progress-bar --show-unsupported --show-pass --show-xfail --max-time 3600 --time-tests ${{ inputs.extra_lit_opts }}"
cmake --build build-e2e --target check-sycl-e2e
- name: Detect hung tests
shell: powershell
- name: Detect hung tests
if: always()
shell: powershell
run: |
$exitCode = 0
$hungTests = Get-Process | Where-Object { ($_.Path -match "llvm\\install") -or ($_.Path -match "llvm\\build-e2e") }
$hungTests | Foreach-Object {
$exitCode = 1
echo "Test $($_.Path) hung!"
Stop-Process -Force $_
}
exit $exitCode
Invoke-WebRequest -Uri "https://raw.githubusercontent.com/intel/llvm/refs/heads/sycl/devops/scripts/windows_detect_hung_tests.ps1" -OutFile "windows_detect_hung_tests.ps1"
powershell.exe -File windows_detect_hung_tests.ps1
exit $LASTEXITCODE
- name: Cleanup
shell: cmd
if: always()
Expand Down
Loading