[CI] Add more Windows hung test checks #16859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarnex
force-pushed
the
hungtest
branch
2 times, most recently
from
cd69b01 to
cb9e183
Compare
sarnex
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
Signed-off-by: Sarnie, Nick <nick.sarnie@intel.com>
Comment on lines
83
to
85
| Invoke-WebRequest -Uri "https://raw.githubusercontent.com/intel/llvm/refs/heads/sycl/devops/scripts/windows_detect_hung_tests.ps1" -OutFile "windows_detect_hung_tests.ps1" | ||
| powershell.exe -File windows_detect_hung_tests.ps1 | ||
| exit $LASTEXITCODE |
There was a problem hiding this comment.
I think this should NOT result in any failure.
There was a problem hiding this comment.
couple of points here
- the single place we call it today already does
- im worried we will never catch hung tests if we dont fail because otherwise the only way to catch it would be to manually read the ci logs
| @@ -47,6 +47,13 @@ jobs: | |||
| environment: WindowsCILock | |||
| env: ${{ fromJSON(inputs.env) }} | |||
| steps: | |||
| - name: Detect hung tests | |||
There was a problem hiding this comment.
Same comments apply to this file.
Signed-off-by: Sarnie, Nick <nick.sarnie@intel.com>
Signed-off-by: Sarnie, Nick <nick.sarnie@intel.com>
aelovikov-intel
approved these changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Obviously we shouldn't have to do this, but these hang issues are causing serious CI issues and annoying users.
If there is a hung test detected, CI will fail after killing the process, so we should still catch the hung tests.
I can't add an action instead of downloading the script because you need to do a (cached) checkout to get the action file and that tries to reset the git repo which fails if there's locked files.