You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Feels like it defeats the purpose of a validation layer if the adapters have to implement all the error checking that's in the validation layer, just in case the validation layer isn't enabled? As if a validation layer isn't being used, then i'd imagine that the goal is that the code can run more permanently without the overhead of lots of error checking.
Regardless, I'd prefer a patch that touched all the UR adapter implementations of urCommandBufferCreateExp and consistently either checked pCommandBufferDesc for null pointer or not. As you've pointed out a few lines up, we sometimes do this and sometimes don't, and that's true for other adapters outside of OpenCL too. So introducing consistency would be a better overall improvement to the codebase.
We should leave checking entry point parameters to the validation layer. We should take a pass at the code base at removing unnecessary checks which will be performed by the validation layer.
The text was updated successfully, but these errors were encountered:
Originally posted by @EwanC in #17615 (comment)
We should leave checking entry point parameters to the validation layer. We should take a pass at the code base at removing unnecessary checks which will be performed by the validation layer.
The text was updated successfully, but these errors were encountered: