Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated instagocb version in example #565

Closed
wants to merge 1 commit into from

Conversation

nithinputhenveettil
Copy link
Member

No description provided.

@nithinputhenveettil nithinputhenveettil requested a review from a team January 9, 2024 17:47
)

replace github.com/instana/go-sensor/instrumentation/instagocb => ../../instrumentation/instagocb
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can keep the replace directive in example so that it will be tested against the local code

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sanojsubran : Good point 👍🏾 We can keep the replace directive here. 😊

@sanojsubran sanojsubran requested a review from a team January 9, 2024 19:36
@sanojsubran sanojsubran removed the request for review from a team January 9, 2024 19:37
@nithinputhenveettil
Copy link
Member Author

nithinputhenveettil commented Jan 10, 2024

Closing this PR as the change is not needed anymore.

@nithinputhenveettil nithinputhenveettil deleted the fixing-couchbase-example branch January 10, 2024 04:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants