Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added instaredisv2 version in the readme comment for automation script #505

Closed
wants to merge 1 commit into from

Conversation

nithinputhenveettil
Copy link
Member

This PR updates missing comment for automation script in instaredisv2 README.

Copy link
Contributor

@willianpc willianpc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Pls keep in mind that the script is not yet ready for sub directories.
As Sanoj is not around at the moment I cannot tell if this could break the script in any way, so we should be prepared for a rollback :)

@nithinputhenveettil
Copy link
Member Author

LGTM. Pls keep in mind that the script is not yet ready for sub directories. As Sanoj is not around at the moment I cannot tell if this could break the script in any way, so we should be prepared for a rollback :)

LGTM. Pls keep in mind that the script is not yet ready for sub directories. As Sanoj is not around at the moment I cannot tell if this could break the script in any way, so we should be prepared for a rollback :)

You are right. According to this line, https://github.com/instana/go-sensor/blob/main/version_updater.sh#L76, the script will only check for packages in instrumentation folder, not in the sub folders.

I will close this PR. :) thanks for this finding man.

@nithinputhenveettil nithinputhenveettil deleted the fix-go-redis-version branch November 30, 2023 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants