Refactor/home #12
Merged
Refactor/home #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HiHoi
reviewed
May 6, 2024
HANE24/View/Home/HeaderView.swift
Outdated
Comment on lines
62
to
66
| #Preview { | ||
| @StateObject var homeVM = HomeVM() | ||
|
|
||
| return HeaderView(homeManager: homeVM) | ||
| } |
There was a problem hiding this comment.
오 이런 선언방식에 프리뷰도 사용이 가능하군요. 참고하겠습니다
HANE24/View/Home/NoticeView.swift
Outdated
| @Binding var showNotice: Bool | ||
| var notice: Notice | ||
| var body: some View { | ||
| public var body: some View { |
There was a problem hiding this comment.
public으로 선언되어있는 NoticeModifier를 적용시키기 위함이었습니다!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
이슈 (번호도 함께 작성해주세요)
해당 사항 (중복 선택)
반영 브랜치
refactor/home -> dev
ex) feat/login -> dev
변경 사항
Home Tab과 관련된 뷰 및 비즈니스 로직에 대한 분리를 진행하였습니다
HomeView
HomeVM
그 외
ex) 로그인 시, 구글 소셜 로그인 기능을 추가했습니다.