docs(inlineEditable): update documentation of inline editable field #2251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samyak3009
force-pushed
the
docs-inline-editable-fields
branch
from
edaeec4 to
8d83164
Compare
samyak3009
force-pushed
the
docs-inline-editable-fields
branch
2 times, most recently
from
fe99671 to
ed3479a
Compare
Comment on lines
-116
to
-120
| <tr style={{verticalAlign: "top"}}> | ||
| <td>Placeholder<br/></td> | ||
| <td><placeholder></td> | ||
| <td>-</td> | ||
| </tr> |
There was a problem hiding this comment.
Please check this once why are we removing the placeholder from the table as it is a valid configuration present in the component.
There was a problem hiding this comment.
@anuradha9712 i have checked this with designer they want this to be removed from here and want the documentation exactly same as it is in design.
samyak3009
force-pushed
the
docs-inline-editable-fields
branch
from
ed3479a to
0ce2dfb
Compare
anuradha9712
approved these changes
Jun 26, 2024
Comment on lines
-142
to
-146
| <tr style={{verticalAlign: "top"}}> | ||
| <td>Placeholder<br/></td> | ||
| <td><placeholder></td> | ||
| <td>-</td> | ||
| </tr> |
There was a problem hiding this comment.
Please check this once why are we removing the placeholder from the table as it is a valid configuration present in the component.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
...
Does this close any currently open issues?
...
Any other comments?
...
Dependent PRs/Commits
...
Describe breaking changes, if any.
...
Checklist
Check all those that are applicable and complete.
masterbranch