feat(avatar): add disabled state in avatar component #2232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anuradha9712
force-pushed
the
feat-avatar-disabled-state
branch
from
af6189d to
62a3195
Compare
anuradha9712
force-pushed
the
feat-avatar-disabled-state
branch
from
944738d to
a7a140b
Compare
anuradha9712
force-pushed
the
feat-avatar-disabled-state
branch
from
a7a140b to
81e0104
Compare
please check this once, if i am using a avatar wrapped in a div which is having `ellipsis--noWrap` class then its focus state is breaking.
|
samyak3009
requested changes
Jun 20, 2024
| @@ -72,7 +87,10 @@ export const Avatar = (props: AvatarProps) => { | |||
| ? children.trim().slice(0, initialsLength) | |||
| : `${firstName ? firstName.trim()[0] : ''}${lastName ? lastName.trim()[0] : ''}`; | |||
|
|
|||
| const tooltip = children && typeof children === 'string' ? children : `${firstName || ''} ${lastName || ''}` || ''; | |||
| const tooltip = | |||
There was a problem hiding this comment.
Please create a separate function for this instead of writing conditional code as it look complex to read at first glance.
|
@samyak3009 In case of Avatar been used with Overflow Text wrapped inside div, the 
|
anuradha9712
force-pushed
the
feat-avatar-disabled-state
branch
from
46f2b24 to
008691a
Compare
samyak3009
approved these changes
Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
...
Does this close any currently open issues?
...
Any other comments?
...
Dependent PRs/Commits
...
Describe breaking changes, if any.
...
Checklist
Check all those that are applicable and complete.
masterbranch