Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix build deps #13

Merged
merged 2 commits into from
Mar 18, 2024
Merged

fix build deps #13

merged 2 commits into from
Mar 18, 2024

Conversation

beer-1
Copy link
Member

@beer-1 beer-1 commented Mar 18, 2024

cargo resolver normally unify the features, so it make test only features are enabled on live chain, so use build and dev dependencies to enable testing feature for compiler.

https://doc.rust-lang.org/cargo/reference/features.html

Summary by CodeRabbit

Summary by CodeRabbit

  • Refactor
    • Removed unnecessary imports and added a new import for gas algebra.
    • Added conditional imports for testing purposes.
    • Swapped the order of imports for NativeStakingContext and NativeTableContext in the initia_move_natives module.

@beer-1 beer-1 self-assigned this Mar 18, 2024
@beer-1 beer-1 requested a review from a team as a code owner March 18, 2024 07:32
Copy link

coderabbitai bot commented Mar 18, 2024

Walkthrough

The changes encompass refactoring imports in the query.rs file within the natives crate and reordering imports in move_unit.rs within the e2e-move-tests crate. These adjustments streamline dependencies and enhance organization within the codebase.

Changes

File Path Change Summary
crates/natives/src/query.rs Removed specific imports, added NumBytes import, and included conditional imports.
crates/e2e-move-tests/src/tests/move_unit.rs Reordered imports for NativeStakingContext and NativeTableContext in initia_move_natives module.

Poem

Code paths intertwine and twist,
Imports dance, a refactor's bliss.
Files reshaped in the coding light,
A bunny's touch, code feels right. 🐰✨

Note

Pull Request Summarized by CodeRabbit Free

Your organization is on the Free plan. CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please upgrade your subscription to CodeRabbit Pro by visiting https://coderabbit.ai


Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

@beer-1 beer-1 merged commit 262ba95 into main Mar 18, 2024
@beer-1 beer-1 deleted the feat/fix-build-deps branch March 18, 2024 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant