Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add view functions to dex to allow query by denoms #12

Merged
merged 2 commits into from
Mar 18, 2024

Conversation

beer-1
Copy link
Member

@beer-1 beer-1 commented Mar 18, 2024

Summary by CodeRabbit

  • New Features
    • Introduced a new PairByDenomResponse struct.
    • Added a new function get_all_pairs_by_denom to retrieve pairs based on denominations.
  • Refactor
    • Replaced pair objects with pair_denom strings in various functions for improved consistency.
    • Modified function signatures to accept pair_denom: String instead of pair: Object<Config>.
    • Updated logic within functions to use metadata conversion for denominations.

@beer-1 beer-1 self-assigned this Mar 18, 2024
@beer-1 beer-1 requested a review from a team as a code owner March 18, 2024 03:33
Copy link

coderabbitai bot commented Mar 18, 2024

Walkthrough

The recent changes in the dex and minitia_stdlib modules of the initia_stdlib involve introducing a new PairByDenomResponse struct, transitioning from pair objects to pair_denom strings, and enhancing functionality to handle denominations more effectively.

Changes

File Summary
precompile/modules/initia_stdlib/sources/dex.move
precompile/modules/minitia_stdlib/sources/dex.move
- Introduce PairByDenomResponse struct
- Update functions to use pair_denom strings
- Add get_all_pairs_by_denom function
- Modify function signatures to accept pair_denom: String
- Enhance logic for denomination metadata conversion

Poem

In the code's dance, a tale spun,
PairByDenomResponse, a new one.
From pairs to denoms, the shift profound,
Dex and minitia, a duo bound.
🐇✨📜

Note

Pull Request Summarized by CodeRabbit Free

Your organization is on the Free plan. CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please upgrade your subscription to CodeRabbit Pro by visiting https://coderabbit.ai


Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

Copy link
Contributor

@ALPAC-4 ALPAC-4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@beer-1 beer-1 merged commit 88f9628 into main Mar 18, 2024
1 check passed
@beer-1 beer-1 deleted the feat/add-view-functions-for-dex branch March 18, 2024 04:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants