-
Notifications
You must be signed in to change notification settings - Fork 222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: remove redundant -path argument before -prune #347
base: main
Are you sure you want to change the base?
Conversation
📝 WalkthroughWalkthroughThe pull request updates the Changes
Sequence Diagram(s)sequenceDiagram
participant U as User
participant S as protocgen.sh
participant F as Find Command
U->>S: Execute protocgen.sh
S->>F: Run find command using -prune after "./initia" and "./ibc"
F-->>S: Return filtered proto directory list
S->>S: Process .proto files based on received directories
S-->>U: Complete processing and output results
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
scripts/protocgen.sh (1)
11-11
: LGTM! Efficient simplification of the find command.The removal of the redundant
-path
argument before-prune
is a good optimization. The command correctly excludes./initia
and./ibc
directories from the search while finding all.proto
files in other directories.Consider adding a comment explaining the find command's behavior:
+# Find all .proto files excluding ./initia and ./ibc directories, then extract unique parent directories proto_dirs=$(find ./initia ./ibc -prune -o -name '*.proto' -print0 | xargs -0 -n1 dirname | sort | uniq)
Description
-path
was unnecessarily used before-prune
. Since-prune
already prevents recursion in./initia
and./ibc
, the extra argument wasn’t needed.Cleaned it up to simplify the command without changing behavior.
Author Checklist
I have...
!
in the type prefix if API or client breaking changeReviewers Checklist
I have...