fix(select-rich): block arrow key interaction when singleOption is set #2474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gerjanvangeest
requested review from
tlouisse,
narzac,
Knorgias,
okadurin and
ryubro
as code owners
🦋 Changeset detectedLatest commit: 8bd3c4c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
gerjanvangeest
force-pushed
the
fix/select-rich-singleOption
branch
from
7bc3f5c to
8bd3c4c
Compare
tlouisse
reviewed
Feb 13, 2025
| elReadOnly.dispatchEvent(new KeyboardEvent('keyup', { key: 'ArrowDown' })); | ||
| expect(elReadOnly.opened).to.be.false; | ||
|
|
||
| elReadOnly.dispatchEvent(new KeyboardEvent('keyup', { key: 'ArrowUp' })); | ||
| expect(elReadOnly.opened).to.be.false; | ||
|
|
There was a problem hiding this comment.
Should these events be fired from focusable element (invokerNode)?
And should they bubble? (Or wrap them in a mimic method that uses sendKeys?)
There was a problem hiding this comment.
The function is on the lion-select-rich directly. It already has an todo next to the function to move it to the invoker.
It wouldn't hurt to wrap them in a mimic method. But let's do that in a future task.
tlouisse
approved these changes
Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did